On Mon, Jun 19, 2023 at 12:37 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Mon, Jun 19, 2023 at 6:50 AM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > > > On Sat, Jun 17, 2023 at 6:45 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > > > On Tue, May 16, 2023 at 8:00 PM Masahiko Sawada <sawada.m...@gmail.com> > > > wrote: > > > > > > > > On Thu, May 11, 2023 at 5:12 PM Masahiko Sawada <sawada.m...@gmail.com> > > > > wrote: > > > > > > > > > > > > > After thinking more about it, I realized that this is not a problem > > > > specific to HEAD. ISTM the problem is that by commit 7b64e4b3, we drop > > > > the stats entry of subscription that is not associated with a > > > > replication slot for apply worker, but we missed the case where the > > > > subscription is not associated with both replication slots for apply > > > > and tablesync. So IIUC we should backpatch it down to 15. > > > > > > > > > > I agree that it should be backpatched to 15. > > > > > > > Since in pg15, since we don't create the subscription stats at CREATE > > > > SUBSCRIPTION time but do when the first error is reported, > > > > > > > > > > AFAICS, the call to pgstat_create_subscription() is present in > > > CreateSubscription() in 15 as well, so, I don't get your point. > > > > IIUC in 15, pgstat_create_subscription() doesn't create the stats > > entry. See commit e0b01429590. > > > > Thanks for the clarification. Your changes looks good to me though I > haven't tested it.
Thanks for reviewing the patch. Pushed. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
