Hi Manuel,

On 29.05.2018 16:19, Manuel Kniep wrote:
Hi,

attached patch passes PGOPTIONS env variable to pg_regress in
pgxs.mk

This is especially useful when developing extensions for different
postgres versions where some session_variables might or might not
exists.

Consider something like this in an extensions makefile:

ifeq ($(shell test $(VERSION_NUM) -ge 90600; echo $$?),0) PGOPTIONS+=
"--max_parallel_workers_per_gather=0" endif

But also when there are many testfiles it might be convenient to
align some session parameter globally In the Makefile.

Have you considered using EXTRA_REGRESS_OPTS variable in extension's
Makefile?

EXTRA_REGRESS_OPTS=--temp-config=$(top_srcdir)/$(subdir)/extra.conf

Here extra.conf is implied to be a file in extension's root directory which contains additional server options.
This would only work for `make check` though, not `make installcheck`.

--
Ildar Musin
i.mu...@postgrespro.ru

Reply via email to