On Fri, Jul 21, 2023 at 1:39 AM Ashutosh Bapat <ashutosh.bapat....@gmail.com> wrote: > > On Thu, Jul 20, 2023 at 9:11 AM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > > > Okay, changed it accordingly. > > > > > > > oops, forgot to attach the patch. > > > > WFM > > @@ -3367,7 +3367,7 @@ apply_dispatch(StringInfo s) > default: > ereport(ERROR, > (errcode(ERRCODE_PROTOCOL_VIOLATION), > - errmsg("invalid logical replication message type > \"%c\"", action))); > + errmsg("invalid logical replication message type > \"??? (%d)\"", action))); > > I think we should report character here since that's what is visible > in the code and also the message types are communicated as characters > not integers. Makes debugging easier. Context may report integer as an > additional data point.
I think it could confuse us if an invalid message is not a printable character. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com