On Wed, Jul 26, 2023 at 03:28:55PM +0100, Dagfinn Ilmari Mannsåker wrote: > Shouldn't these be calling `OidIsValid(…)`, not comparing directly to > `InvalidOid`?
I think that they should use OidIsValid() on correctness ground, and that's the style I prefer. Now, I don't think that these are worth changing now except if some of the surrounding code is changed for a different reason. One reason is that this increases the odds of conflicts when backpatching on a stable branch. -- Michael
signature.asc
Description: PGP signature
