On Thu, Aug 3, 2023 at 9:35 AM Peter Smith <smithpb2...@gmail.com> wrote: > > On Wed, Aug 2, 2023 at 11:19 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > On Wed, Aug 2, 2023 at 4:09 PM Melih Mutlu <m.melihmu...@gmail.com> wrote: > > > > > > PFA an updated version with some of the earlier reviews addressed. > > > Forgot to include them in the previous email. > > > > > > > It is always better to explicitly tell which reviews are addressed but > > anyway, I have done some minor cleanup in the 0001 patch including > > removing includes which didn't seem necessary, modified a few > > comments, and ran pgindent. I also thought of modifying some variable > > names based on suggestions by Peter Smith in an email [1] but didn't > > find many of them any better than the current ones so modified just a > > few of those. If you guys are okay with this then let's commit it and > > then we can focus more on the remaining patches. > > > > I checked the latest patch v25-0001. > > LGTM. >
Thanks, I have pushed 0001. Let's focus on the remaining patches. -- With Regards, Amit Kapila.
