On Thu, 3 Aug 2023 at 16:59, Tatsuo Ishii <is...@sraoss.co.jp> wrote:
> > On Thu, 3 Aug 2023 at 13:25, Tatsuo Ishii <is...@sraoss.co.jp> wrote: > > > >> > Greetings, > >> > > >> > Attached is a patch which introduces a file protocol.h. Instead of > using > >> > the actual characters everywhere in the code this patch names the > >> > characters and removes the comments beside each usage. > >> > >> > +#define DESCRIBE_PREPARED 'S' > >> > +#define DESCRIBE_PORTAL 'P' > >> > >> You use these for Close message as well. I don't like the idea because > >> Close is different message from Describe message. > >> > >> What about adding following for Close too use them instead? > >> > >> #define CLOSE_PREPARED 'S' > >> #define CLOSE_PORTAL 'P' > >> > > > > Good catch. > > I recall when writing this it was a bit hacky. > > What do you think of PREPARED_SUB_COMMAND and PORTAL_SUB_COMMAND > instead > > of duplicating them ? > > Nice. Looks good to me. > New patch attached which uses PREPARED_SUB_COMMAND and PORTAL_SUB_COMMAND instead and uses PQMSG_REQ_* and PQMSG_RESP_* as per Alvaro's suggestion Dave Cramer
0001-Created-protocol.h.patch
Description: Binary data
