On Thu, Aug 10, 2023 at 4:11 PM Ashutosh Bapat <ashutosh.bapat....@gmail.com> wrote: > > Please add this to commitfest so that it's not forgotten. >
Added [1], thanks [1]: https://commitfest.postgresql.org/44/4495/ > On Wed, Aug 9, 2023 at 8:37 PM Junwang Zhao <zhjw...@gmail.com> wrote: > > > > On Wed, Aug 9, 2023 at 10:46 PM Ashutosh Bapat > > <ashutosh.bapat....@gmail.com> wrote: > > > > > > On Wed, Aug 9, 2023 at 9:30 AM Junwang Zhao <zhjw...@gmail.com> wrote: > > > > > > > > In function `BackendXidGetPid`, when looping every proc's > > > > TransactionId, there is no need to access its PGPROC since there > > > > is shared memory access: `arrayP->pgprocnos[index]`. > > > > > > > > Though the compiler can optimize this kind of inefficiency, I > > > > believe we should ship with better code. > > > > > > > > > > Looks good to me. However, I would just move the variable declaration > > > with their assignments inside the if () rather than combing the > > > expressions. It more readable that way. > > > > yeah, make sense, also checked elsewhere using the original style, > > attachment file > > keep that style, thanks ;) > > > > > > > > -- > > > Best Wishes, > > > Ashutosh Bapat > > > > > > > > -- > > Regards > > Junwang Zhao > > > > -- > Best Wishes, > Ashutosh Bapat -- Regards Junwang Zhao