Peter Geoghegan <p...@bowt.ie> writes: > On Fri, Aug 11, 2023 at 2:25 PM Andres Freund <and...@anarazel.de> wrote: >> We could a test that fails when there's some mis-indented code. That seems >> like it might catch things earlier?
+1 for including this in CI tests > It definitely would. That would go a long way towards addressing my > concerns. But I suspect that that would run into problems that stem > from the fact that the buildfarm is testing something that isn't all > that simple. Don't typedefs need to be downloaded from some other > blessed buildfarm animal? No. I presume koel is using src/tools/pgindent/typedefs.list, which has always been the "canonical" list but up to now we've been lazy about maintaining it. Part of the new regime is that typedefs.list should now be updated on-the-fly by patches that add new typedefs. We should still compare against the buildfarm's list periodically; but I imagine that the primary result of that will be to remove no-longer-used typedefs from typedefs.list. regards, tom lane