On Fri, Aug 18, 2023 at 10:51 PM Hayato Kuroda (Fujitsu) <kuroda.hay...@fujitsu.com> wrote: > > Dear Peter, > > PSA new version patch set. >
I've looked at the v22 patch set, and here are some comments: 0001: Do we need regression tests to make sure that the slot's confirmed_flush_lsn matches the LSN of the latest shutdown_checkpoint record? 0002: + <step> + <title>Prepare for publisher upgrades</title> + Should this step be done before "8. Stop both servers" as it might require to disable subscriptions and to drop 'lost' replication slots? Why is there no explanation about the slots' confirmed_flush_lsn check as prerequisites? Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com