On Tue, Aug 29, 2023 at 6:40 AM Michael Paquier <mich...@paquier.xyz> wrote: > > On Mon, Aug 28, 2023 at 09:46:07PM +0800, Junwang Zhao wrote: > > Yeah, it makes sense to me, or maybe just `PQputCopyEnd(...) == -1`, > > let's wait for some other opinions. > > One can argue that PQputCopyEnd() returning 0 could be possible in an > older version of libpq these callers are linking to, but this has > never existed from what I can see (just checked down to 8.2 now). > Anyway, changing these callers may create some backpatching conflicts, > so I'd let them as they are, and just fix the comment.
sure, thanks for the explanation. > -- > Michael -- Regards Junwang Zhao