Dear Peter, Thanks for giving comments! PSA new version. I replied only comment 8 because others were replied by Amit.
> .../t/003_logical_replication_slots.pl > > 8. Consider adding one more test > > Maybe there should also be some "live check" test performed (e.g. > using --check, and a running old_cluster). > > This would demonstrate pg_upgrade working successfully even when the > WAL records are not consumed (because LSN checks would be skipped in > check_old_cluster_for_valid_slots function). I was ignored the case because it did not improve improve code coverage, but indeed, no one has checked the feature. I'm still not sure what should be, but added. I want to hear your opinions. Furthermore, based on comments from Dilip [1], added the comment and check_new_cluster_logical_replication_slots() was modified. IIUC pg_upgrade does not have method to handle plural form, so if-statement was used. If you have better options, please tell me. [1]: https://www.postgresql.org/message-id/CAFiTN-tgm9wCTyG4co%2BVZhyFTnzh-KoPtYbuH9bRFmxroJ34EQ%40mail.gmail.com Best Regards, Hayato Kuroda FUJITSU LIMITED
v29-0001-Persist-logical-slots-to-disk-during-a-shutdown-.patch
Description: v29-0001-Persist-logical-slots-to-disk-during-a-shutdown-.patch
v29-0002-pg_upgrade-Allow-to-replicate-logical-replicatio.patch
Description: v29-0002-pg_upgrade-Allow-to-replicate-logical-replicatio.patch
