On Mon, Jul 10, 2023 at 02:37:24PM -0700, Nikolay Samokhvalov wrote:
> Maybe. It will require changes in other parts of this doc.
> Thinking (here:
> https://gitlab.com/postgres/postgres/-/merge_requests/18/diffs)
>
> Meanwhile, attached is v2
>
> thanks for the comments
I looked over this issue thoroughly and I think I see the cause of the
confusion. In step 8 we say:
8. Stop both servers
Streaming replication and log-shipping standby servers can remain
---
running until a later step.
Of course this has to be "must" and it would be good to explain why,
which I have done in the attached patch.
Secondly, in step 9 we say "verify the LSNs", but have a parenthetical
sentence that explains why they might not match:
(There will be a mismatch if old standby servers were shut down before
the old primary or if the old standby servers are still running.)
People might take that to mean that it is okay if this is the reason
they don't match, which is incorrect. Better to tell them to keep the
streaming replication and log-shipping servers running so we don't need
that sentence.
The instructions are already long so I am hesitant to add more text
without a clear purpose.
--
Bruce Momjian <br...@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
diff --git a/doc/src/sgml/ref/pgupgrade.sgml b/doc/src/sgml/ref/pgupgrade.sgml
index 7816b4c685..f9c16a5cdb 100644
--- a/doc/src/sgml/ref/pgupgrade.sgml
+++ b/doc/src/sgml/ref/pgupgrade.sgml
@@ -380,8 +380,8 @@ NET STOP postgresql-&majorversion;
</para>
<para>
- Streaming replication and log-shipping standby servers can
- remain running until a later step.
+ Streaming replication and log-shipping standby servers must be
+ running during this shutdown so they receive all changes.
</para>
</step>
@@ -394,8 +394,6 @@ NET STOP postgresql-&majorversion;
servers are caught up by running <application>pg_controldata</application>
against the old primary and standby clusters. Verify that the
<quote>Latest checkpoint location</quote> values match in all clusters.
- (There will be a mismatch if old standby servers were shut down
- before the old primary or if the old standby servers are still running.)
Also, make sure <varname>wal_level</varname> is not set to
<literal>minimal</literal> in the <filename>postgresql.conf</filename> file on the
new primary cluster.
