On Wed, Sep 13, 2023 at 11:40:25AM +0530, Bharath Rupireddy wrote: > When a snapshot file reading fails in ImportSnapshot(), it errors out > with "invalid snapshot identifier". This message better suits for > snapshot identifier parsing errors which is being done just before the > file reading. The attached patch adds a generic file reading error > message with path to help distinguish if the issue is with snapshot > identifier parsing or file reading.
f = AllocateFile(path, PG_BINARY_R);
if (!f)
ereport(ERROR,
- (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
- errmsg("invalid snapshot identifier: \"%s\"", idstr)));
+ (errcode_for_file_access(),
+ errmsg("could not open file \"%s\" for reading: %m",
+ path)));
Agreed that this just looks like a copy-pasto. The path provides
enough context about what's being read, so using this generic error
message is fine. Will apply if there are no objections.
--
Michael
signature.asc
Description: PGP signature
