On Wed, Jun 6, 2018 at 9:21 AM, Ashutosh Bapat < ashutosh.ba...@enterprisedb.com> wrote:
> On Wed, Jun 6, 2018 at 8:11 AM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: > > On Mon, Mar 5, 2018 at 8:13 PM, Rajkumar Raghuwanshi > > <rajkumar.raghuwan...@enterprisedb.com> wrote: > >> On Wed, Feb 7, 2018 at 2:00 PM, Ashutosh Bapat > >> Changed partition-wise statement to partitionwise. > >> Attached re-based patch. > >> > >>> The patch looks good to me. I don't think we can reduce it further. > >>> But we need some tests to test PWJ with default partitions. Marking > >>> this as ready for committer. > > > > Hi Rajkumar, > > > > partition_join ... FAILED > > > Thanks Thomas for patch review. That made my heart stop for fraction of a second. I thought, something > happened which caused partition_join test fail in master. But then I > realised you are talking about Rajkumar's patch and test in that > patch. I think it's better to start a separate thread discussing his > patch, before I loose my heart ;) Yeah, that would be better. here is the new thread with updated patch. https://www.postgresql.org/message-id/CAKcux6ky5YeZAY74qSh-ayPZZEQchz092g71iXXbC0%2BE3xoscA%40mail.gmail.com Thanks & Regards, Rajkumar Raghuwanshi QMG, EnterpriseDB Corporation
