On Fri, Sep 29, 2023 at 5:27 PM Hayato Kuroda (Fujitsu) <kuroda.hay...@fujitsu.com> wrote: > > Yeah, the approach enforces developers to check the decodability. > But the benefit seems smaller than required efforts for it because the > function > would be used only by pg_upgrade. Could you tell me if you have another use > case > in mind? We may able to adopt if we have...
I'm attaching 0002 patch (on top of v45) which implements the new decodable callback approach that I have in mind. IMO, this new approach is extensible, better than the current approach (hard-coding of certain WAL records that may be generated during pg_upgrade) taken by the patch, and helps deal with the issue that custom WAL resource managers can have with the current approach taken by the patch. > Also, this approach cannot be backported. Neither the current patch as-is. I'm not looking at backporting this feature right now, but making it as robust and extensible as possible for PG17. Thoughts? -- Bharath Rupireddy PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
v45-0001-pg_upgrade-Allow-to-replicate-logical-replicatio.patch
Description: Binary data
v45-0002-Add-rm_is_record_decodable-callback-for-WAL-rmgr.patch
Description: Binary data
