Hi, On 2023-10-05 13:37:38 -0400, Tom Lane wrote: > Andres Freund <and...@anarazel.de> writes: > > I think you can just pass c_args directly to executable() here, I think > > adding > > c_args to default_bin_args would be a bad idea. > > Hm. IIUC that would result in an error if someone did try to > put some c_args into default_bin_args, and I didn't think it would > be appropriate for this code to fail in such a case. Still, I see > there are a bunch of other ways to inject globally-used compilation > flags, so maybe you're right that it'd never need to happen.
I think the other ways of injecting c_args compose better (and indeed other options are either injected globally, or via declare_dependency()). Greetings, Andres Freund
