On Mon, Oct 23, 2023 at 2:00 PM Alexander Lakhin <exclus...@gmail.com> wrote: > 23.10.2023 12:47, Alexander Korotkov wrote: > > I think this patch makes substantial improvement to query planning. > > It has received plenty of reviews. The code is currently in quite > > good shape. I didn't manage to find the cases when this optimization > > causes significant overhead to planning time. Even if such cases will > > be spotted there is a GUC option to disable this feature. So, I'll > > push this if there are no objections. > > On a quick glance, I've noticed following typos/inconsistencies in the > patch, which maybe worth fixing: > s/cadidates/candidates/ > s/uniquiness/uniqueness/ > s/selfjoin/self-join/ > s/seperate/separate/ > > Also, shouldn't the reference "see generate_implied_equalities" be > "see generate_implied_equalities_for_column"?
Fixed all of the above. Thank you for catching this! ------ Regards, Alexander Korotkov
0001-Remove-useless-self-joins-v48.patch
Description: Binary data