On Fri, 3 Nov 2023 at 19:37, Tomas Vondra <tomas.von...@enterprisedb.com> wrote: > > Hi, > > I took a look at this patch today. I had to rebase the patch, due to > some minor bitrot related to 9f0602539d (but nothing major). I also did > a couple tiny cosmetic tweaks, but other than that the patch seems OK. > See the attached v6. > [...] > Barring objections, I'll try to push this early next week, after another > round of cleanup.
No hard objections: The principle looks fine. I do think we should choose a better namespace than bs_* for the fields of BrinInsertState, as BrinBuildState already uses the bs_* namespace for its fields in the same file, but that's only cosmetic. Kind regards, Matthias van de Meent Neon (https://neon.tech)
