Aleksander Alekseev,

> Maxim,
> I see both of us accounted for Alexanders feedback and submitted v59.
> Your newer version seems to have issues on cfbot, so resubmitting the
> previous patchset that passes the tests. Please feel free to add
> changes.

For unknown reasons, I do not receive any of your emails from after
2023-11-07 11:57:12 (Message-ID: CAJ7c6TN1hKqNPGrNcq96SUyD=
z61rakgxf8iqq36qr90oud...@mail.gmail.com).
Even after resend.

Anyway, PFA patch set of version 61.  I've made some minor changes in the
0001 and add 004 in order to test actual 64-bit SLRU pages.

As for CF bot had failed on my v59 patch set, this is because of the bug.
It's manifested because of added 64-bit pages tests.
The problem was in segno calculation, since we convert it from file name
using strtol call.  But strtol return long,
which is 4 byte long in x86.

-           segno = (int) strtol(clde->d_name, NULL, 16);
+           segno = strtoi64(clde->d_name, NULL, 16);

-- 
Best regards,
Maxim Orlov.

Attachment: v61-0003-Make-use-FullTransactionId-in-2PC-filenames.patch
Description: Binary data

Attachment: v61-0004-Add-SLRU-tests-for-64-bit-page-case.patch
Description: Binary data

Attachment: v61-0002-Use-larger-segment-file-names-for-pg_notify.patch
Description: Binary data

Attachment: v61-0001-Index-SLRUs-by-64-bit-integers-rather-than-by-32.patch
Description: Binary data

Reply via email to