On Mon, Nov 13, 2023 at 6:19 AM Zhijie Hou (Fujitsu) <houzj.f...@fujitsu.com> wrote: > > On Thursday, November 9, 2023 6:54 PM shveta malik <shveta.ma...@gmail.com> > wrote: > > > > > > PFA v32 patches which has below changes: > > Thanks for updating the patch. > > Here are few comments: > > > 2. > The check for wal_level < WAL_LEVEL_LOGICAL. > > It seems the existing codes disallow slot creation if wal_level is not > sufficient, I am thinking we might need similar check in slot sync worker. > Otherwise, the synced slot could not be used after standby promotion. >
Yes, I agree. We should add this check. > Best Regards, > Hou zj
