On Mon, Nov 20, 2023 at 03:31:20PM -0400, David Steele wrote: > On 11/20/23 15:03, Andres Freund wrote: >> Besides the phrasing and the additional log message (I have no opinion about >> whether it should be backpatched or not), I used %u for TimelineID as >> appropriate, and added a comma before "on timeline".
The "starting/restarting/completed recovery" line sounds better here, so I'm OK with your suggestions. > I still wonder if we need "base backup" in the messages? That sort of > implies (at least to me) you used pg_basebackup but that may not be the > case. Or just s/base backup/backup/? > Other than that, looks good for HEAD. Whether we back patch or not is > another question, of course. I'd rather see more information in the back-branches more quickly, so count me in the bucket of folks in favor of a backpatch. -- Michael
signature.asc
Description: PGP signature
