On Fri, Nov 24, 2023 at 1:53 PM Drouvot, Bertrand <bertranddrouvot...@gmail.com> wrote: > > On 11/24/23 4:35 AM, Zhijie Hou (Fujitsu) wrote: > > On Thursday, November 23, 2023 11:45 PM Drouvot, Bertrand > > <bertranddrouvot...@gmail.com> wrote: > > > > IOW, the logical slot's LSN can still be advanced after the > > walreceiver shutdown if it was far bebind the physical slot's LSN. > > > > oh yeah right, it would need much more work/discussion to handle this case. > > As mentioned up-thread for publisher/subscriber I think it's fine > (thanks to the replication origin linked to the subscriber) but for > anything else that don't make use of replication origin (or similar > approach to re-start the decoding from the right place after promotion) > I feel like the user experience is not as good. > > It may not be worth it to work on it for V1 but maybe something to keep > in mind as improvement for later? >
Agreed, we can think of improving it in the future but there is no correctness issue with the current implementation (not trying to do the last fetch after the promotion signal). -- With Regards, Amit Kapila.