On Mon, Nov 27, 2023 at 2:15 PM Drouvot, Bertrand <bertranddrouvot...@gmail.com> wrote: > > Hi, > > On 11/27/23 7:02 AM, Zhijie Hou (Fujitsu) wrote: > > On Monday, November 27, 2023 12:03 PM Zhijie Hou (Fujitsu) > > <houzj.f...@fujitsu.com> wrote: > >> > >> Attach the V38 patch set which addressed all comments in [1][2] except for > >> the > >> ones that mentioned above. > >> > >> [1] > >> https://www.postgresql.org/message-id/CAHut%2BPv-yu71ogj_hRi6cCtmD5 > >> 5bsyw7XTxj1Nq8yVFKpY3NDQ%40mail.gmail.com > >> [2] > >> https://www.postgresql.org/message-id/CAHut%2BPuEGX5kr0xh06yv8ndoA > >> QvDNedoec1OqOq3GMxDN6p%3D9A%40mail.gmail.com > > > > I didn't increment the patch version, sorry for that. Attach the same patch > > set > > but increment the patch version to V39. > > Thanks! > > It looks like v39 does not contain (some / all?) the changes that have been > done in v38 [1]. > > For example, slot_exists_in_list() still exists in v39 while it was renamed to > validate_sync_slot() in v38. >
Yes, I noticed that and informed Hou-san about this. New patches will be posted soon with the correction. Meanwhile, please review v38 instead if you intend to review patch002 right now. v39 is supposed to have changes in patch001 alone. thanks Shveta thanks Shveta
