Commits look fine to me, but I hate the new target names... Luckily, I just use plain ninja, so I don't interact with that.

 +    for name, v in targets_info_byname.items():
 +        if len(targets_info_byname[name]) > 1:

My only comment is that you could reverse the logic and save yourself an indentation.

- if len(targets_info_byname[name]) > 1:
+ if len(targets_info_byname[name]) <= 1:
+     continue

But whatever you want.

--
Tristan Partin
Neon (https://neon.tech)


Reply via email to