Hi, Sorry for the late reply.
On Fri, 6 Oct 2023 at 17:07, Tom Lane <t...@sss.pgh.pa.us> wrote: > > As a quick cross-check, I searched our commit log to see how many > README-only commits there were so far this year. I found 11 since > January. (Several were triggered by the latest round of pgindent > code and process changes, so maybe this is more than typical.) > > Not sure what that tells us about the value of changing the CI > logic, but it does seem like it could be worth the one-liner > change needed to teach buildfarm animals to ignore READMEs. I agree that it could be worth implementing this logic on buildfarm animals. In case we want to implement the same logic on the CI, I added a new version of the patch; it skips CI completely if the changes are only in the README files. -- Regards, Nazir Bilal Yavuz Microsoft
From 6c268233d13262a31965baf2dbb42913d83dab1d Mon Sep 17 00:00:00 2001 From: Nazir Bilal Yavuz <byavu...@gmail.com> Date: Thu, 14 Dec 2023 16:23:28 +0300 Subject: [PATCH v3] If the changes are only in the README files, skip all the tasks. If the changes are only in the README files, skip all the tasks to save CI time. --- .cirrus.tasks.yml | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/.cirrus.tasks.yml b/.cirrus.tasks.yml index e137769850..dfd12f8b04 100644 --- a/.cirrus.tasks.yml +++ b/.cirrus.tasks.yml @@ -4,6 +4,12 @@ # further details, see src/tools/ci/README +# If the changes are only in the README files, skip all the tasks. +# +# This skip is overriden in 'SanityCheck' task. So, the same check is +# added 'SanityCheck' task too. +skip: changesIncludeOnly('**/README') + env: # The lower depth accelerates git clone. Use a bit of depth so that # concurrent tasks and retrying older jobs have a chance of working. @@ -55,11 +61,12 @@ on_failure_meson: &on_failure_meson task: name: SanityCheck - # If a specific OS is requested, don't run the sanity check. This shortens - # push-wait-for-ci cycle time a bit when debugging operating system specific - # failures. Uses skip instead of only_if, as cirrus otherwise warns about - # only_if conditions not matching. - skip: $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-os-only:.*' + # Don't run the sanity check if the changes are only in the README files or + # if a specific OS is requested. The latter shortens push-wait-for-ci cycle + # time a bit when debugging operating system specific failures. Uses skip + # instead of only_if, as cirrus otherwise warns about only_if conditions not + # matching. + skip: $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-os-only:.*' || changesIncludeOnly('**/README') env: CPUS: 4 -- 2.43.0