Another set of comments, about the patch that adds pg_combinebackup:
Make sure all the options are listed in a consistent order. We have lately changed everything to be alphabetical. This includes:
- reference page pg_combinebackup.sgml - long_options listing - getopt_long() argument - subsequent switch - (--help output, but it looks ok as is)Also, in pg_combinebackup.sgml, the option --sync-method is listed as if it does not take an argument, but it does.