On Tue, Dec 19, 2023 at 12:37 PM Masahiko Sawada <sawada.m...@gmail.com> wrote:
>
> On Mon, Dec 18, 2023 at 3:41 PM John Naylor <johncnaylo...@gmail.com> wrote:
> > Let's do it in just one place. In TidStoreCreate(), do
> >
> > /* clamp max_bytes to at least the size of the empty tree with
> > allocated blocks, so it doesn't immediately appear full */
> > ts->control->max_bytes = Max(max_bytes, {rt, shared_rt}_memory_usage);
> >
> > Then we can get rid of all the worry about 1MB/2MB, 64kB, 70kB -- all that.
>
> But doesn't it mean that even if we create a shared tidstore with
> small memory, say 64kB, it actually uses 1MB?This sounds like an argument for controlling the minimum DSA segment size. (I'm not really in favor of that, but open to others' opinion) I wasn't talking about that above -- I was saying we should have only one place where we clamp max_bytes so that the tree doesn't immediately appear full.
