On Wed, Dec 20, 2023 at 3:29 PM shveta malik <shveta.ma...@gmail.com> wrote: > > On Wed, Dec 20, 2023 at 9:12 AM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > On Tue, Dec 19, 2023 at 5:30 PM shveta malik <shveta.ma...@gmail.com> wrote: > > > > > > Thanks for reviewing. I have addressed these in v50. > > > > > > > I was looking at this patch to see if something smaller could be > > independently committable. I think we can extract > > pg_get_slot_invalidation_cause() and commit it as that function could > > be independently useful as well. What do you think? > > > > Sure, forked another thread [1] > [1]: > https://www.postgresql.org/message-id/CAJpy0uBpr0ym12%2B0mXpjcRFA6N%3DanX%2BYk9aGU4EJhHNu%3DfWykQ%40mail.gmail.com >
Thanks, thinking more, we can split the patch into the following three patches which can be committed separately (a) Allowing the failover property to be set for a slot via SQL API and subscription commands (b) sync slot worker infrastructure (c) GUC standby_slot_names and the the corresponding wait logic in server-side. Thoughts? -- With Regards, Amit Kapila.
