On Wed, Dec 20, 2023 at 12:21:05PM +0530, vignesh C wrote: > On Tue, 19 Dec 2023 at 21:22, Nathan Bossart <nathandboss...@gmail.com> wrote: >> I'm not sure we should proceed with rewriting most/all eligible foreach >> loops. I think it's fine to use the new macros in new code or to update >> existing loops in passing when changing nearby code, but rewriting >> everything likely just introduces back-patching pain in return for little >> discernible gain. > > +1 for this. Let's just provide the for_each macros to be used for new code. > This means that the > 0003-Use-new-foreach_xyz-macros-in-a-few-places.patch will not be > present in the final patch right?
It might be worth changing at least one of each type to make sure the macros compile, but yes, I don't think we need to proceed with any sort of bulk changes of existing loops for now. BTW I think v7-0001 and v7-0002 are in pretty good shape. I'm going to mark this as ready-for-committer and see if I can get those two committed sooner than later. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com
