On Sat, Dec 23, 2023 at 9:14 PM Michael Paquier <mich...@paquier.xyz> wrote: > > On Mon, Nov 13, 2023 at 07:06:15PM -0500, Melanie Plageman wrote: > > As best I can tell, our best case scenario is Thomas' streaming read API > > goes in, we add vacuum as a user, and we can likely remove the skip > > range logic. > > This does not prevent the work you've been doing in 0001 and 0002 > posted upthread, right? Some progress is always better than no > progress
Correct. Peter and I were mainly discussing next refactoring steps as we move toward combining the prune, freeze, and VM records. This thread's patches stand alone. > I can see the appeal behind doing 0001 actually to keep > the updates of the block numbers closer to where we determine if > relation truncation is safe of not rather than use an intermediate > state in LVPagePruneState. Exactly. > 0002 is much, much, much trickier.. Do you have specific concerns about its correctness? I understand it is an area where we have to be sure we are correct. But, to be fair, that is true of all the pruning and vacuuming code. - Melanie