On 18 June 2018 at 14:36, Amit Langote <langote_amit...@lab.ntt.co.jp> wrote: > On 2018/06/15 20:41, David Rowley wrote: >> If the top level Append is the UNION ALL one, then there won't be any >> partitioned_rels. If that's what you mean by no-op then, yeah. There >> are no duplicate locks already obtained in the parent with the child >> Append node. > > Yeah, that's what I meant to say. I looked for whether the locks end up > being taken twice, once in the UNION ALL parent's ExecInitAppend and then > again in the individual child Appends' ExecInitAppend, but that they > don't, so the patch is right.
Thanks for looking. Robert, do you have any objections to the proposed patch? -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
