Hi, On Sat, Jan 06, 2024 at 10:18:52AM -0600, Nathan Bossart wrote: > On Sat, Jan 06, 2024 at 09:03:52AM +0000, Bertrand Drouvot wrote: > > Sorry, I missed this in my first review, but instead of: > > > > - input: files('../../backend/storage/lmgr/lwlocknames.txt'), > > + input: [files('../../backend/storage/lmgr/lwlocknames.txt'), > > files('../../backend/utils/activity/wait_event_names.txt')], > > > > what about? > > > > input: files( > > '../../backend/storage/lmgr/lwlocknames.txt', > > '../../backend/utils/activity/wait_event_names.txt', > > ), > > > > It's done that way in doc/src/sgml/meson.build for example. > > I fixed this in v4.
Thanks! + input: [files( + '../../backend/storage/lmgr/lwlocknames.txt', + '../../backend/utils/activity/wait_event_names.txt')], I think the "[" and "]" are not needed here. Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com