On Fri, Jan 12, 2024 at 10:59 AM torikoshia <torikos...@oss.nttdata.com> wrote: > > > Thanks for reviewing! > > Updated the patch merging your suggestions except below points: > > > + cstate->num_errors = 0; > > Since cstate is already initialized in below lines, this may be > redundant. > > | /* Allocate workspace and zero all fields */ > | cstate = (CopyFromStateData *) palloc0(sizeof(CopyFromStateData)); > > > > + Assert(!cstate->escontext->details_wanted); > > I'm not sure this is necessary, considering we're going to add other > options like 'table' and 'log', which need details_wanted soon. > > > -- > Regards,
make save_error_to option cannot be used with COPY TO. add redundant test, save_error_to with COPY TO test.
v2-0001-minor-refactor.no-cfbot
Description: Binary data