On Wed, 17 Jan 2024 at 21:10, Robert Haas <robertmh...@gmail.com> wrote: > > On Wed, Jan 17, 2024 at 1:42 PM Matthias van de Meent > <boekewurm+postg...@gmail.com> wrote: > > Sure, added in attached. > > I think this mostly looks good now but I just realized that I think > this needs rephrasing: > > + To restore incremental backups the tool <xref > linkend="app-pgcombinebackup"/> > + is used, which combines incremental backups with a base backup and > + <glossterm linkend="glossary-wal">WAL</glossterm> to restore a > + <glossterm linkend="glossary-db-cluster">database cluster</glossterm> to > + a consistent state. > > The way this is worded, at least to me, it makes it sound like > pg_combinebackup is going to do the WAL recovery for you, which it > isn't. Maybe: > > To restore incremental backups the tool <xref > linkend="app-pgcombinebackup"/> is used, which combines incremental > backups with a base backup. Afterwards, recovery can use <glossterm > linkend="glossary-wal">WAL</glossterm> to bring the <glossterm > linkend="glossary-db-cluster">database cluster</glossterm> to a > consistent state.
Sure, that's fine with me. Kind regards, Matthias van de Meent Neon (https://neon.tech)
