On Wed, Jan 17, 2024 at 4:31 PM Peter Geoghegan <p...@bowt.ie> wrote: > Actually, I suppose that we couldn't apply it independently of > nindexes==0. Then we'd call FreeSpaceMapVacuumRange() before our > second pass over the heap takes place for those LP_DEAD-containing > heap pages scanned since the last round of index/heap vacuuming took > place (or since VACUUM began). We need to make sure that the FSM has > the most recent possible information known to VACUUM, which would > break if we applied VACUUM_FSM_EVERY_PAGES rules when nindexes > 0. > > Even still, the design of VACUUM_FSM_EVERY_PAGES seems questionable to me.
I agree with all of this. I thought I'd said all of this, actually, in my prior email, but perhaps it wasn't as clear as it needed to be. But I also said one more thing that I'd still like to hear your thoughts about, which is: why is it right to update the FSM after the second heap pass rather than the first one? I can't help but suspect this is an algorithmic holdover from pre-HOT days, when VACUUM's first heap pass was read-only and all the work happened in the second pass. Now, nearly all of the free space that will ever become free becomes free in the first pass, so why not advertise it then, instead of waiting? Admittedly, HOT is not yet 15 years old, so maybe it's too soon to adapt our VACUUM algorithm for it. *wink* -- Robert Haas EDB: http://www.enterprisedb.com
