On Tue, Jan 9, 2024 at 11:15 PM Zhijie Hou (Fujitsu) <houzj.f...@fujitsu.com> wrote: > > On Tuesday, January 9, 2024 9:17 AM Peter Smith <smithpb2...@gmail.com> wrote: > > ... > > > > 2. ALTER_REPLICATION_SLOT ... FAILOVER > > > > + <variablelist> > > + <varlistentry> > > + <term><literal>FAILOVER [ <replaceable > > class="parameter">boolean</replaceable> ]</literal></term> > > + <listitem> > > + <para> > > + If true, the slot is enabled to be synced to the physical > > + standbys so that logical replication can be resumed after > > failover. > > + </para> > > + </listitem> > > + </varlistentry> > > + </variablelist> > > > > This syntax says passing the boolean value is optional. So it needs to be > > specified here in the docs that not passing a value would be the same as > > passing the value true. > > The behavior that "not passing a value would be the same as passing the value > true " is due to the rule of defGetBoolean(). And all the options of commands > in this document behave the same in this case, therefore I think we'd better > add document for it in a general place in a separate patch/thread instead of > mentioning this in each option's paragraph. >
Hi Hou-san, I did as suggested and posted a patch for this in another thread [1]. Please see if it is OK. ====== [1] https://www.postgresql.org/message-id/CAHut%2BPtDWSmW8uiRJF1LfGQJikmo7V2jdysLuRmtsanNZc7fNw%40mail.gmail.com Kind Regards, Peter Smith. Fujitsu Australia