Hi! On Fri, Jan 19, 2024 at 2:37 PM torikoshia <torikos...@oss.nttdata.com> wrote: > Thanks for making the patch!
The patch is pushed! The proposed changes are incorporated excluding this. > > - /* If SAVE_ERROR_TO is specified, skip rows > > with soft errors */ > > + /* If ON_ERROR is specified with IGNORE, skip > > rows with soft errors */ > > This is correct now, but considering future works which add other > options like "file 'copy.log'" and > "table 'copy_log'", it may be better not to limit the case to 'IGNORE'. > How about something like this? > > If ON_ERROR is specified and the value is not STOP, skip rows with > soft errors I think when we have more options, then we wouldn't just skip rows with soft errors but rather save them. So, I left this comment as is for now. ------ Regards, Alexander Korotkov
