Hi, On Fri, 2 Feb 2024 at 12:11, Artur Zakirov <zaar...@gmail.com> wrote: > > On Fri, 2 Feb 2024 at 09:41, Nazir Bilal Yavuz <byavu...@gmail.com> wrote: > > You seem right, nice catch. Also, this change makes the check in > > > > snprintf(summarydir, sizeof(summarydir), "%s/%s/summaries", > > basedir, > > PQserverVersion(conn) < MINIMUM_VERSION_FOR_PG_WAL ? > > "pg_xlog" : "pg_wal"); > > > > redundant. PQserverVersion(conn) will always be higher than > > MINIMUM_VERSION_FOR_PG_WAL. > > Thank you both for the comments. Indeed, that part now looks redundant. > I've attached a patch to remove checking MINIMUM_VERSION_FOR_PG_WAL.
Thanks for the update. The patch looks good to me. -- Regards, Nazir Bilal Yavuz Microsoft
