On Tuesday, February 13, 2024 7:30 PM Bertrand Drouvot <bertranddrouvot...@gmail.com> wrote: > > On Tue, Feb 13, 2024 at 04:08:23AM +0000, Zhijie Hou (Fujitsu) wrote: > > On Tuesday, February 13, 2024 9:16 AM Zhijie Hou (Fujitsu) > <houzj.f...@fujitsu.com> wrote: > > > > > > Here is the new version patch which addressed above and most of > > > Bertrand's comments. > > > > > > TODO: trying to add one test for the case the slot is valid on > > > primary while the synced slots is invalidated on the standby. > > > > Here is the V85_2 patch set that added the test and fixed one typo, > > there are no other code changes. > > Thanks! > > Out of curiosity I ran a code coverage and the result for slotsync.c can be > found > in [1]. > > It appears that: > > - only one function is not covered (slotsync_failure_callback()).
Thanks for the test ! I think slotsync_failure_callback can be covered easier in the next slotsync worker patch on worker exit, I will post that after rebasing. Best Regards, Hou zj
