On Mon, Feb 19, 2024 at 10:31 AM Robert Haas <robertmh...@gmail.com> wrote: > > On Mon, Feb 19, 2024 at 10:10 AM Kyotaro Horiguchi > <horikyota....@gmail.com> wrote: > > A recent commit (7a424ece48) added the following message: > > > > > could not sync slot information as remote slot precedes local slot: > > > remote slot "%s": LSN (%X/%X), catalog xmin (%u) local slot: LSN > > > (%X/%X), catalog xmin (%u) > > > > Since it is a bit overloaded but doesn't have a separator between > > "catalog xmin (%u)" and "local slot:", it is somewhat cluttered. Don't > > we need something, for example a semicolon there to improve > > readability and reduce clutter? > > I think maybe we should even revise the message even more. In most > places we do not just print out a whole bunch of values, but use a > sentence to connect them.
I have tried to reword the msg, please have a look. thanks Shveta
v1-0001-Reword-LOG-msg-for-slot-sync.patch
Description: Binary data
