On Tue, 20 Feb 2024 at 13:40, Bharath Rupireddy <bharath.rupireddyforpostg...@gmail.com> wrote: > On Mon, Feb 19, 2024 at 8:25 PM Japin Li <japi...@hotmail.com> wrote: >> [2] >> +# Ensure checkpoint doesn't come in our way >> +$primary->append_conf('postgresql.conf', qq( >> + min_wal_size = 2MB >> + max_wal_size = 1GB >> + checkpoint_timeout = 1h >> + autovacuum = off >> +)); >> >> Keeping the same indentation might be better. > > The autovacuum line looks mis-indented in the patch file. However, I > now ran src/tools/pgindent/perltidyrc > src/test/recovery/t/041_wal_source_switch.pl on it. >
Thanks for updating the patch. It seems still with the wrong indent.
diff --git a/src/test/recovery/t/041_wal_source_switch.pl b/src/test/recovery/t/041_wal_source_switch.pl index 082680bf4a..b5eddba1d5 100644 --- a/src/test/recovery/t/041_wal_source_switch.pl +++ b/src/test/recovery/t/041_wal_source_switch.pl @@ -18,9 +18,9 @@ $primary->init( # Ensure checkpoint doesn't come in our way $primary->append_conf( 'postgresql.conf', qq( - min_wal_size = 2MB - max_wal_size = 1GB - checkpoint_timeout = 1h + min_wal_size = 2MB + max_wal_size = 1GB + checkpoint_timeout = 1h autovacuum = off )); $primary->start; @@ -85,7 +85,7 @@ my $offset = -s $standby->logfile; my $apply_delay = $retry_interval * 5; $standby->append_conf( 'postgresql.conf', qq( -recovery_min_apply_delay = '${apply_delay}ms' + recovery_min_apply_delay = '${apply_delay}ms' )); $standby->start;