On Thu, Feb 22, 2024 at 5:23 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Thu, Feb 22, 2024 at 4:35 PM Bertrand Drouvot > <bertranddrouvot...@gmail.com> wrote: > > > > On Thu, Feb 22, 2024 at 04:01:34PM +0530, shveta malik wrote: > > > On Thu, Feb 22, 2024 at 3:44 PM Bertrand Drouvot > > > <bertranddrouvot...@gmail.com> wrote: > > > > > > > > Hi, > > > > > > > > Thanks! > > > > > > > > Some random comments about v92_001 (Sorry if it has already been > > > > discussed > > > > up-thread): > > > > > > Thanks for the feedback. The patch is pushed 15 minutes back. > > > > Yeah, saw that after I send the comments ;-) > > > > There is a BF failure. See > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2024-02-22%2010%3A13%3A03. > > The initial analysis suggests that for some reason, the primary went > down after the slot sync worker was invoked the first time. See the > below in the primary's LOG: >
The reason is that the test failed waiting on below LOG: ### Reloading node "standby1" # Running: pg_ctl -D /home/ec2-user/bf/root/HEAD/pgsql.build/src/test/recovery/tmp_check/t_040_standby_failover_slots_sync_standby1_data/pgdata reload server signaled timed out waiting for match: (?^:LOG: slot sync worker started) at t/040_standby_failover_slots_sync.pl line 376. Now, on standby, we see a LOG like 2024-02-22 10:57:35.432 UTC [2721638:1] LOG: 00000: slot sync worker started. Even then the test failed and the reason is that it has an extra 0000 before the actual message which is due to log_error_verbosity = verbose in config. I think here the test's log matching code needs to have a more robust log line matching code. -- With Regards, Amit Kapila.