On 3/3/24 07:10, Andy Fan wrote: > > Hi, > > Here is a updated version, the main changes are: > > 1. an shared_detoast_datum.org file which shows the latest desgin and > pending items during discussion. > 2. I removed the slot->pre_detoast_attrs totally. > 3. handle some pg_detoast_datum_slice use case. > 4. Some implementation improvement. >
I only very briefly skimmed the patch, and I guess most of my earlier comments still apply. But I'm a bit surprised the patch needs to pass a MemoryContext to so many places as a function argument - that seems to go against how we work with memory contexts. Doubly so because it seems to only ever pass CurrentMemoryContext anyway. So what's that about? regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
