Greetings, * Jeff Davis (pg...@j-davis.com) wrote: > On Tue, 2024-02-27 at 09:48 -0500, Stephen Frost wrote: > > Attached is an updated patch which drops the 'such as' and adds a > > sentence mentioning that BRIN is the only in-core summarizing index. > > The original patch reads more clearly to me. In v4, summarizing (the > exception) feels like it's dominating the description. > > Also, is it standard practice to backport this kind of doc update? I > ordinarily wouldn't be inclined to do so, but v4 seems targeted at 16 > as well.
I do think this change should be back-ported to when the change happened, otherwise the documentation won't reflect what's in the product for that version... > Attached my own suggested wording that hopefully addresses Stephen and > Alvaro's concerns. I agree that it's tricky to write so I took a more > minimalist approach: > * I got rid of the "In summary" sentence because (a) it's confusing > now that we're talking about summarizing indexes; and (b) it's not > summarizing anything, it's just redundant. > * I removed the mention partial or expression indexes. It's a bit > redundant and doesn't seem especially helpful in this context. Just to point it out- the "In summary" did provide a bit of a summary, before the 'partial or expression indexes' bit was removed. That said, I tend to still agree with these changes as I feel that users will generally be able to infer that this applies to partial and expression indexes without it having to be spelled out to them. > If this is agreeable I can commit it. Great, thanks! Stephen
signature.asc
Description: PGP signature