On Fri, Mar 8, 2024 at 8:09 AM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > Yesterday I've confirmed the something like the below fixes the > problem happened in Windows CI:
Glad you shared before I went and did it. > --- a/src/test/modules/test_radixtree/meson.build > +++ b/src/test/modules/test_radixtree/meson.build > @@ -12,6 +12,7 @@ endif > > test_radixtree = shared_module('test_radixtree', > test_radixtree_sources, > + link_with: host_system == 'windows' ? pgport_srv : [], I don't see any similar coding elsewhere, so that leaves me wondering if we're missing something. On the other hand, maybe no test modules use files in src/port ... > kwargs: pg_test_mod_args, > ) > test_install_libs += test_radixtree > > But I'm not sure it's the right fix especially because I guess it > could raise "AddressSanitizer: odr-violation" error on Windows. Well, it's now at zero definitions that it can see, so I imagine it's possible that adding the above would not cause more than one. In any case, we might not know since as far as I can tell the MSVC animals don't have address sanitizer. I'll look around some more, and if I don't get any revelations, I guess we should go with the above.