On 2024-Mar-18, Peter Eisentraut wrote: > * src/bin/pg_basebackup/pg_createsubscriber.c > > I think the connection string handling is not robust against funny > characters, like spaces, in database names etc.
Maybe it would be easier to deal with this by passing around a struct with keyword/value pairs that can be given to PQconnectdbParams (and keeping dbname as a param that's passed separately, so that it can be added when one is needed), instead of messing with the string conninfos; then you don't have to worry about quoting. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ "If you have nothing to say, maybe you need just the right tool to help you not say it." (New York Times, about Microsoft PowerPoint)
