Hi! In commit 7b5275eec more tests and test coverage were added into pg_resetwal/t/001_basic.pl. All the added stuff are pretty useful in my view. Unfortunately, there were some magic constants been used. In overall, this is not a problem. But while working on 64 bit XIDs I've noticed these changes and spent some time to figure it out what this magic values are stands fore.
And it turns out that I’m not the only one. So, by Svetlana Derevyanko's suggestion, I made this patch. I add constants, just like we did in verify_heapam tests. Sidenote here: in defines in multixact.c TransactionId type used, but I'm sure this is not correct, since we're dealing here with MultiXactId and MultiXactOffset. For now, this is obviously not a problem, since sizes of this particular types are equal. But this will manifest itself when we switch to the 64 bits types for MultiXactOffset or MultiXactId. As always, reviews and opinions are very welcome! -- Best regards, Maxim Orlov.
v1-0001-Refactor-pg_resetwal-t-001_basic.pl.patch
Description: Binary data
