On Wed, 2024-03-27 at 13:44 +0700, John Naylor wrote: > Thanks for the pointers! In v20-0001, I've drafted checking thes > spelling first, since pg_attribute_no_sanitize_alignment has a > similar > version check. Then it checks for no_sanitize_address using > __has_attribute, which goes back to gcc 5. That's plenty for the > buildfarm and CI, and I'm not sure it's worth expending additional > effort to cover more cases. (A similar attribute exists for MSVC in > case it comes up.)
0001 looks good to me, thank you. > v21-0003 adds a new file hashfn_unstable.c for convenience functions > and converts all the duplicate frontend uses of hash_string_pointer. Why not make hash_string() inline, too? I'm fine with it either way, I'm just curious why you went to the trouble to create a new .c file so it didn't have to be inlined. Regards, Jeff Davis