On Thu, Apr 04, 2024 at 07:09:53PM -0400, Tom Lane wrote: > If you have time, that'd be great. What I suspect is that that > machine's readline isn't regurgitating the string verbatim but is > doing something fancy with backspaces or other control characters. > But we need to see what it's actually emitting before there's > much hope of adjusting the expected-output regex.
I have been able to reproduce the failure manually and your patch is
providing more information, indeed, as of:
[10:21:44.017](0.002s) ok 83 - \r works
[10:24:45.462](181.445s) # pump_until: timeout expired when searching
for "(?^::\{\?VERBOSITY} )" with stream: "\echo :{?VERB^G^Mpostgres=#
\echo :\{\?VERBOSITY\} "
psql query timed out at
/home/pgbuildfarm/git/postgres/src/bin/psql/../../../src/test/perl/PostgreSQL/Test/BackgroundPsql.pm
line 281.
This stuff is actually kind of funny on this host, "\echo :{?VERB\t"
completes to something incorrect, as of:
postgres=# \echo :\{\?VERBOSITY\}
Attaching the log file, for reference. Now I can see that this uses
libedit at 3.1-20181209, which is far from recent. I'd be OK to just
remove libedit from the build to remove this noise, still I am
wondering if 927332b95e77 got what it was trying to achieve actually
right. Thoughts?
--
Michael
# Checking port 58896
# Found port 58896
Name: main
Data directory:
/home/pgbuildfarm/git/postgres/src/bin/psql/tmp_check/t_010_tab_completion_main_data/pgdata
Backup directory:
/home/pgbuildfarm/git/postgres/src/bin/psql/tmp_check/t_010_tab_completion_main_data/backup
Archive directory:
/home/pgbuildfarm/git/postgres/src/bin/psql/tmp_check/t_010_tab_completion_main_data/archives
Connection string: port=58896 host=/tmp/PFPt99SXDc
Log file:
/home/pgbuildfarm/git/postgres/src/bin/psql/tmp_check/log/010_tab_completion_main.log
[10:21:42.754](0.070s) # initializing database system by copying initdb template
# Running: cp -RPp /home/pgbuildfarm/git/postgres/tmp_install/initdb-template
/home/pgbuildfarm/git/postgres/src/bin/psql/tmp_check/t_010_tab_completion_main_data/pgdata
# Running:
/home/pgbuildfarm/git/postgres/src/bin/psql/../../../src/test/regress/pg_regress
--config-auth
/home/pgbuildfarm/git/postgres/src/bin/psql/tmp_check/t_010_tab_completion_main_data/pgdata
### Starting node "main"
# Running: pg_ctl -w -D
/home/pgbuildfarm/git/postgres/src/bin/psql/tmp_check/t_010_tab_completion_main_data/pgdata
-l
/home/pgbuildfarm/git/postgres/src/bin/psql/tmp_check/log/010_tab_completion_main.log
-o --cluster-name=main start
waiting for server to start.... done
server started
# Postmaster PID for node "main" is 7305
#### Begin standard error
psql:<stdin>:6: WARNING: wal_level is insufficient to publish logical changes
HINT: Set wal_level to "logical" before creating subscriptions.
#### End standard error
[10:21:43.237](0.483s) ok 1 - complete SEL<tab> to SELECT
[10:21:43.239](0.002s) ok 2 - \r works
[10:21:43.241](0.001s) ok 3 - complete sel<tab> to select
[10:21:43.251](0.010s) ok 4 - complete t<tab> to tab1
[10:21:43.253](0.002s) ok 5 - \r works
[10:21:43.256](0.004s) ok 6 - complete my<tab> to mytab when there are multiple
choices
[10:21:43.260](0.004s) ok 7 - offer multiple table choices
[10:21:43.262](0.002s) ok 8 - finish completion of one of multiple table choices
[10:21:43.265](0.003s) ok 9 - \r works
[10:21:43.269](0.004s) ok 10 - complete "my<tab> to "mytab when there are
multiple choices
[10:21:43.272](0.004s) ok 11 - offer multiple quoted table choices
[10:21:43.275](0.002s) ok 12 - finish completion of one of multiple quoted
table choices
[10:21:43.277](0.002s) ok 13 - control-U works
[10:21:43.281](0.004s) ok 14 - complete a mixed-case name
[10:21:43.282](0.002s) ok 15 - control-U works
[10:21:43.287](0.005s) ok 16 - automatically fold case
[10:21:43.643](0.355s) ok 17 - \r works
[10:21:43.645](0.002s) ok 18 - complete \DRD<tab> to \drds
[10:21:43.647](0.002s) ok 19 - control-U works
[10:21:43.652](0.005s) ok 20 - complete schema when relevant
[10:21:43.657](0.005s) ok 21 - complete schema-qualified name
[10:21:43.659](0.002s) ok 22 - \r works
[10:21:43.664](0.005s) ok 23 - automatically fold case in schema-qualified name
[10:21:43.666](0.002s) ok 24 - \r works
[10:21:43.673](0.007s) ok 25 - complete index name for referenced table
[10:21:43.675](0.002s) ok 26 - \r works
[10:21:43.680](0.005s) ok 27 - complete index name for referenced table, with
downcasing
[10:21:43.682](0.002s) ok 28 - \r works
[10:21:43.688](0.006s) ok 29 - complete index name for referenced table, with
schema and quoting
[10:21:43.690](0.002s) ok 30 - \r works
[10:21:43.698](0.008s) ok 31 - complete qualified name from object reference
[10:21:43.700](0.002s) ok 32 - \r works
[10:21:43.704](0.003s) ok 33 - filename completion with one possibility
[10:21:43.714](0.010s) ok 34 - \r works
[10:21:43.717](0.003s) ok 35 - filename completion with multiple possibilities
[10:21:43.719](0.002s) ok 36 - control-U works
[10:21:43.722](0.003s) ok 37 - quoted filename completion with one possibility
[10:21:43.724](0.002s) ok 38 - control-U works
[10:21:43.727](0.003s) ok 39 - quoted filename completion with multiple
possibilities
[10:21:43.729](0.002s) ok 40 - offer multiple file choices
[10:21:43.731](0.002s) ok 41 - control-U works
[10:21:43.739](0.009s) ok 42 - offer multiple enum choices
[10:21:43.741](0.002s) ok 43 - control-U works
[10:21:43.746](0.005s) ok 44 - enum labels are case sensitive
[10:21:43.748](0.002s) ok 45 - control-U works
[10:21:43.844](0.096s) ok 46 - offer partial timezone name
[10:21:43.900](0.056s) ok 47 - complete partial timezone name
[10:21:43.901](0.001s) ok 48 - control-U works
[10:21:43.903](0.001s) ok 49 - set completion case to 'lower'
[10:21:43.908](0.005s) ok 50 - offer keyword column for input CO<TAB>,
COMP_KEYWORD_CASE = lower
[10:21:43.910](0.002s) ok 51 - \r works
[10:21:43.911](0.002s) ok 52 - set completion case to 'upper'
[10:21:43.916](0.005s) ok 53 - offer keyword COLUMN for input co<TAB>,
COMP_KEYWORD_CASE = upper
[10:21:43.918](0.002s) ok 54 - \r works
[10:21:43.920](0.002s) ok 55 - set completion case to 'preserve-lower'
[10:21:43.925](0.005s) ok 56 - offer keyword column for input co<TAB>,
COMP_KEYWORD_CASE = preserve-lower
[10:21:43.927](0.002s) ok 57 - \r works
[10:21:43.929](0.002s) ok 58 - set completion case to 'preserve-upper'
[10:21:43.934](0.005s) ok 59 - offer keyword COLUMN for input CO<TAB>,
COMP_KEYWORD_CASE = preserve-upper
[10:21:43.936](0.002s) ok 60 - \r works
[10:21:43.941](0.005s) ok 61 - offer keyword from SchemaQuery
[10:21:43.943](0.001s) ok 62 - \r works
[10:21:43.944](0.001s) ok 63 - check create_command_generator
[10:21:43.946](0.001s) ok 64 - \r works
[10:21:43.951](0.005s) ok 65 - check words_after_create
[10:21:43.953](0.002s) ok 66 - \r works
[10:21:43.956](0.003s) ok 67 - check VersionedQuery
[10:21:43.957](0.001s) ok 68 - \r works
[10:21:43.959](0.002s) ok 69 - check ANALYZE (VERBOSE ...
[10:21:43.961](0.002s) ok 70 - \r works
[10:21:43.969](0.008s) ok 71 - complete a GUC name
[10:21:43.978](0.009s) ok 72 - complete a GUC enum value
[10:21:43.980](0.002s) ok 73 - \r works
[10:21:43.984](0.004s) ok 74 - load plpgsql extension
[10:21:43.989](0.006s) ok 75 - complete prefix of a GUC name
[10:21:43.996](0.006s) ok 76 - complete a qualified GUC name
[10:21:44.006](0.010s) ok 77 - complete a qualified GUC enum value
[10:21:44.008](0.002s) ok 78 - \r works
[10:21:44.010](0.002s) ok 79 - complete a psql variable name
[10:21:44.011](0.002s) ok 80 - complete a psql variable value
[10:21:44.013](0.002s) ok 81 - \r works
[10:21:44.015](0.002s) ok 82 - complete an interpolated psql variable name
[10:21:44.017](0.002s) ok 83 - \r works
[10:24:45.462](181.445s) # pump_until: timeout expired when searching for
"(?^::\{\?VERBOSITY} )" with stream: "\echo :{?VERB
postgres=# \echo :\{\?VERBOSITY\} "
psql query timed out at
/home/pgbuildfarm/git/postgres/src/bin/psql/../../../src/test/perl/PostgreSQL/Test/BackgroundPsql.pm
line 281.
# Postmaster PID for node "main" is 7305
### Stopping node "main" using mode immediate
# Running: pg_ctl -D
/home/pgbuildfarm/git/postgres/src/bin/psql/tmp_check/t_010_tab_completion_main_data/pgdata
-m immediate stop
waiting for server to shut down.... done
server stopped
# No postmaster PID for node "main"
[10:24:45.572](0.111s) # Tests were run but no plan was declared and
done_testing() was not seen.
[10:24:45.573](0.001s) # Looks like your test exited with 29 just after 83.
signature.asc
Description: PGP signature
