On Thu, 28 Jun 2018 16:22:15 -0700
"David G. Johnston" <david.g.johns...@gmail.com> wrote:
> On Thu, Jun 28, 2018 at 3:57 PM, Daniel Gustafsson <dan...@yesql.se> wrote:
Thank you for your reviewing!
I attached the updated patch.
>
> > > On 27 Jun 2018, at 18:02, Yugo Nagata <nag...@sraoss.co.jp> wrote:
> >
> > > I found that there isn't explanation about EXCLUDING in CREATE TABLE doc.
> > > Attached is a patch to add this. I would appreciate it if a native
> > English
> > > speaker comments on this.
> >
> > + If <literal>EXCLUDING</literal> option <literal></literal> is
> > specified
> >
> > The empty <literal></literal> seems wrong.
Fixed
> >
> > + after <literal>INCLUDING</literal> options, the specified thing is
> > excluded
> >
> > “thing” sounds a bit vague here (and in the last sentence as well), but I’m
> > also not sure what to use instead. “referenced objects" perhaps?
Fixed.
> >
> > +1 on documenting the EXCLUDING option though.
> >
>
> "is excluded" and "not copied" are redundant to each other and the first
I removed "is excluded".
> sentence is basically redundant with the second.
>
> Maybe try something like:
>
> It is legal to specify the same option multiple times - e.g., "INCLUDING
> option EXCLUDING option" - the outcome is whichever comes last in the
> command (i.e., in the example, option is excluded).
Certainly. However, it seems to me that example is also redundant.
I rewrote this as follows:
It is legal to specify multiple options for the same kind of object.
If they conflict, latter options always override former options.
Does this make sense?
>
> David J.
--
Yugo Nagata <nag...@sraoss.co.jp>
diff --git a/doc/src/sgml/ref/create_table.sgml b/doc/src/sgml/ref/create_table.sgml
index 2a1eac9..d57af73 100644
--- a/doc/src/sgml/ref/create_table.sgml
+++ b/doc/src/sgml/ref/create_table.sgml
@@ -624,6 +624,13 @@ WITH ( MODULUS <replaceable class="parameter">numeric_literal</replaceable>, REM
<literal>INCLUDING COMMENTS INCLUDING CONSTRAINTS INCLUDING DEFAULTS INCLUDING IDENTITY INCLUDING INDEXES INCLUDING STATISTICS INCLUDING STORAGE</literal>.
</para>
<para>
+ If <literal>EXCLUDING</literal> option is specified after
+ <literal>INCLUDING</literal> option, the referenced objects are not copied.
+ This is tipically used after <literal>INCLUDING ALL</literal>.
+ It is legal to specify multiple options for the same kind of object.
+ If they conflict, latter options always override former options.
+ </para>
+ <para>
Note that unlike <literal>INHERITS</literal>, columns and
constraints copied by <literal>LIKE</literal> are not merged with similarly
named columns and constraints.
